Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling: improve known issues #3254

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Profiling: improve known issues #3254

merged 3 commits into from
Oct 12, 2023

Conversation

inge4pres
Copy link
Contributor

Reason for this PR

The known issues section of Profiling > Get Started is inaccurate.

@inge4pres inge4pres requested a review from a team as a code owner October 4, 2023 13:02
@inge4pres inge4pres self-assigned this Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

A documentation preview will be available soon:

@inge4pres inge4pres mentioned this pull request Oct 5, 2023
Closed
mdbirnstiehl
mdbirnstiehl previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions but otherwise LGTM.

docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
@inge4pres @mdbirnstiehl
Suggestions from code review
7dbcd56 
Co-authored-by: Mike Birnstiehl <[email protected]>
@inge4pres inge4pres enabled auto-merge (squash) October 12, 2023 13:35
@inge4pres inge4pres merged commit 9fc692b into main Oct 12, 2023
4 checks passed
@inge4pres inge4pres deleted the inge4pres-patch-1 branch October 12, 2023 13:56
@inge4pres inge4pres added the backport-8.10 Automated backport with mergify label Oct 12, 2023
mergify bot pushed a commit that referenced this pull request Oct 12, 2023
@inge4pres @mergify
Profiling: improve known issues (#3254)
561e574 
* Profiling: improve known issues

Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit 9fc692b)
@mergify mergify bot mentioned this pull request Oct 12, 2023
Merged
inge4pres added a commit that referenced this pull request Oct 12, 2023
@mergify @inge4pres
Profiling: improve known issues (#3254) (#3271)
b21b551 
* Profiling: improve known issues

Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit 9fc692b)

Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

Assignees

@inge4pres inge4pres

Labels
backport backport-8.10 Automated backport with mergify v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inge4pres @mdbirnstiehl